no1golfpro.co.uk - how can it be improved?
Hi guys,
This is a site that I've been working on for the last couple of months, but I've been wary about posting it up for critique because of it being osCommerce, and therefore, I've not really designed it. Basically guys, I'd like your expert advice to give it the once over and tell me how you think I could improve it.
Now I do know there are a couple of problems. The first is to do with the fact that, certainly on my machine but maybe not on yours, click to enlarge does not always work. Secondly, I'm trying to fix a problem where the "Buy Now" button is visible when the price is £0.00. The graphics aren't great, but I've think I've got rid of all of the default osCommerce cartoony things. There are no speed issues my end, but I do have Broadband and so that will slow me down.
If I remember correctly, the site wasn't too good in 800 x 600 because of the password box at the top stretching across the screen...
As you can see, I still have a bit to do! But I would like your opinions anyway as they always prove useful and you've improved my sites, graphics etc dramatically in the past. I'd be most grateful.
Many thanks
Rob
steve40 posted this at 17:05 — 30th May 2005.
He has: 490 posts
Joined: May 2005
I was wondering why the login box should spread all the way across, and then some at 600X800. I looked at your source code, and you have some bad nesting problems with your tables. You have opened a table without closing the first, and then there are some other difficulties. The whole site should either compress, or expand the same amount.
Timewell posted this at 17:36 — 30th May 2005.
They have: 344 posts
Joined: Jun 2002
Cheers for the speedy response Steve.
Like I said earlier, this is all done by osCommerce so I need to pinpoint the exact code (as it's spread in hundreds of files). I guess you are talking about right at the top where I have 3 tables in as many lines? Obviously, with the amount of tables that I have closing all of them will be a long job...and then to find the end tag would take even longer!
So do you reckon just closing the first table will fix it?
Many thanks
Rob
no1golfpro.co.uk - High quality golf equipment at competitive prices.
steve40 posted this at 19:18 — 30th May 2005.
He has: 490 posts
Joined: May 2005
It would probably help.
Timewell posted this at 15:35 — 31st May 2005.
They have: 344 posts
Joined: Jun 2002
After looking at the code in my header.php, from what I can see it all closes fine....
<!-- loginbox //-->
<?php
if (!tep_session_is_registered('customer_id')) {
?>
<table width="280"><tr> <td>
<?php
$loginboxcontent = tep_draw_form('login', tep_href_link(FILENAME_LOGIN, 'action=process', 'SSL'))
. '<table width="280" border="0" cellspacing="0" cellpadding="0"><tr><td colspan="3" class="smallText">'
.'<tr><td class="smallText">'
. tep_draw_separator('pixel_trans.gif', '2', '1')
. BOX_LOGINBOXH_EMAIL
. '</td><td class="smallText" colspan="3">'
. tep_draw_input_field('email_address', '', 'size="10" maxlength="100" style="width: ' . (BOX_WIDTH-30) . 'px"')
.'</td></tr><tr><td class="smallText">'
. tep_draw_separator('pixel_trans.gif', '2', '1')
. BOX_LOGINBOXH_PASSWORD
. '</td><td class="smallText">'
. tep_draw_password_field('password', '', 'size="10" maxlength="40" style="width: ' . (BOX_WIDTH-30) . 'px"')
. '</td><td class="smallText">'
. '<a href="'
. tep_href_link(FILENAME_PASSWORD_FORGOTTEN, '', 'SSL')
. '">'
. BOX_LOGINBOXH_FORGOT_PASSWORD
. '</a></td></tr><tr><td class="smallText" colspan="3">'
. tep_draw_separator('pixel_trans.gif', '5', '25')
. tep_image_submit('button_login.gif', IMAGE_BUTTON_LOGIN)
. '</form>'
. tep_draw_separator('pixel_trans.gif', '5', '1')
. BOX_LOGINBOXH_TEXT_NEW
. '<a href="'
. tep_href_link(FILENAME_CREATE_ACCOUNT, '', 'SSL')
. '">'
. BOX_LOGINBOXH_NEW
. '</a></td></tr></table>'
;
$info_box_contents = array();
$info_box_contents[] = array('align' => '',
'text' => $loginboxcontent);
new infoBox($info_box_contents);
?>
</td>
</tr></table>
<?php
} else {
// If you want to display anything when the user IS logged in, put it
// in here... Possibly a "You are logged in as :" box or something.
}
?>
<!-- loginbox_eof //-->
no1golfpro.co.uk - High quality golf equipment at competitive prices.
wwwben posted this at 03:00 — 31st May 2005.
He has: 270 posts
Joined: Jan 2005
I think the site looks great ..good work
andy206uk posted this at 12:18 — 31st May 2005.
He has: 1,758 posts
Joined: Jul 2002
I think the header/logo could do with some work.
I know what you mean about editing oscommerce files - absolute nightmare! Have you installed the Simple Template System mod? It makes altering the layout much easer!
Andy
Timewell posted this at 14:02 — 31st May 2005.
They have: 344 posts
Joined: Jun 2002
Ben - thanks for your kind words!
Andy - the logo is not my best effort, I must admit but I have never been fantastic at graphic design, but I guess now is the time to start!
I did have STS on an earlier layout, but I scrapped it and now I think that some of the mods have meant that it would not be compatible with my current setup. Maybe I'm being harsh on myself, but there is something about it which makes me feel that it can be improved somehow.
no1golfpro.co.uk - High quality golf equipment at competitive prices.
demonhale posted this at 22:40 — 1st June 2005.
He has: 3,278 posts
Joined: May 2005
Your site looks good and its on its way... All i could suggest is, i think its better if you align the sign in box at the left side just above the categories, that way users having problems with them could easily see it... Also the quickfind could be very useful so can it be moved somewhere on top? maybe on the divider or something. lastly can you find a better golfing photo? the one on top is ok, but a more saturated version with a good green can be better...
steve40 posted this at 01:57 — 2nd June 2005.
He has: 490 posts
Joined: May 2005
The table that contains the login box is not where the trouble lies. I copied your page code, and ran it through my html editor and CSE validator. The page has some thirty various errors, and warnings. A lot in erroneous table syntax, and nesting errors throughout the entire page. If you do anything to try to change the stretched top margin it will upset the whole page.
The only fix for this page I am afraid, and probably the easier fix; is to completely start over. Or just let it ride, but I would be afraid to say how it will appear to other browsers than IE 6.
Timewell posted this at 13:34 — 2nd June 2005.
They have: 344 posts
Joined: Jun 2002
Ah right. Well that's cleared that up then! Like I say, the anomalies are down to osCommerce and, I guess if I do install the Simple Template System, then I could make the page valid.
no1golfpro.co.uk - High quality golf equipment at competitive prices.
marypainter posted this at 12:40 — 3rd June 2005.
They have: 7 posts
Joined: Jun 2005
Well I like this site....Colour scheme look , everything.
Thanks
Mary
Busy posted this at 11:47 — 5th June 2005.
He has: 6,151 posts
Joined: May 2001
It's very 'green'
*had to throw that pun in there ;)*
Hope you can get that login book/ html sorted, apart from the scroll the login is creating at 800x600 the rest of the layout works well. The font size could be a size bigger.
don't forget to finish your shipping and rates page.
Also on the about page might want to mention if you sell overseas or just in the UK
Timewell posted this at 15:22 — 7th June 2005.
They have: 344 posts
Joined: Jun 2002
Mary - thanks for the comments
Busy - hehe! I'll look into the font sizes. Oh thanks for mentioning the shipping page, I'd totally forgotten about that!
So I guess I'd better get some work done on a new logo or something. I must admit, I do think the logo needs some work on it - but quite what I'd replace it with I don't know!
Incidentally, when you click on a product page, have you noticed whether the Click to Enlarge works every time or not?
no1golfpro.co.uk - High quality golf equipment at competitive prices.
Want to join the discussion? Create an account or log in if you already have one. Joining is fast, free and painless! We’ll even whisk you back here when you’ve finished.