Updating a dB

try something like group = '"$group"' (single quote, double quote - double single)

You could also make your life easier by just having one database query at the bottom and having the database table a switched variable

$query = mysql_query("UPDATE $whatwhere SET group = .....

$whatwhere being the variable that changes depending on the switch
You might want to add a default or if empty check to it though to be safe

I would agree with Busy on using the switch to change a variable, and then do one single query at the bottom. However, I would put the full sql statement into a variable iself, and then do $query = mysql_query($sql);' Also, right before this line, place something like

You can normally leave this line commented out, then uncomment it when you have problems.

So many times I see people who have problems getting a query, insert or update to work, yet they do not actually look at the final sql statement that is sent to the server. Adding this line will let you see this.

Next step after that, if it looks like everything is formatted ok, manually execute the sql statement on the server (either command line, or through something like phpMyAdmin), as this will usually give you a more detailed responce to the error. Plus then you can start breaking down the sql statements to see which part isn't working, executing just parts.

ie. test the WHERE clause by doing a simple SELECT * FROM {dbname} WHERE event = {Whatever data the printed SQL statement showed you}'From here you can see if there were actually any matching rows to update.

Since yours is an error about syntax, I'm guessing just seeing the actual SQL statement will reviel the answer. Here is how I build sql statements:

(note the spaces before the closing quote in each line except the last one!!)

It makes it a little easier when writing, and you can notice more quickly whne you mis a quote becasue one row will stand out a little more.

Hope these tips help.

-Greg

PS. Don't forget to validate the input, and use addslashes to protect the names in case they have quotes, apostrophes, or other characters in them (see http://www.php.net/addslashes)

OK, now it switches a variable, and sends to a general update string, and the update string has the double single single double quoting. That got rid of the syntax error.

Now, I get a parse error on line 66, which happens to be:

I tried it as "UPDATE $location SET ..." and the way it is now. Whats up now? Thanks.

You have unequal quotation marks.

"$group" should be " . $group . " in this case (and all other double quoted variables).

That doesn't seem to solve the problem, I just get more syntax errors, involving the same stuff

I am going to give you the ABSOLUTE correct method. Are yours requires registered globals on (I may have that confused, pretty sure im right with that "rg" statement).

'
Note: The above code assumed you are submitting a form via the "post" method and all the variables EXECEPT $location are coming from that form and are given name enclosed in [''] ie $_POST['foo']. The curly braces allow for single quote to be utilized in the SQL statement without breaking it.

If you were to break up the SQL statement and assigned it to a variable as I gave an example above, then php would have only choked on one section, thus helping you identify which section it is having trouble with...

Addtionally, in line you gave above that is still giving you errors, note that you will also have problems with the actual SQL being sent becasue of the missing spaces. Say the variable $location was Under6Girls, then your sql statement would (in part) look like: UPDATEUnder6GirlsSET group...' instead of UPDATE Under6Girls SET group...'

Again, this is where having the sql in a variable, and then output the content of that variable (while testing the script) before the line that isexecuting the sql statement would help you catch the problem.

-Greg

Alright...exams are over I have time now to do this

I did it the way Greg suggested, concatenating the strings to create a sql statement:

and there error I get is this:You have an error in your SQL syntax. Check the manual that corresponds to your MySQL server version for the right syntax to use near 'group = '6 & Under Girls', name = 'Test', time = '5:15.11', yea'

Where does that "yea" come from? GRAHGH! This is frustrating me...

Don't use reserved characters? & for instance?

that would help, but i'm testing it out under Under6Girls...so that's not the problem...but i'll fix it anyways

The "yea" was most likely it cutting off the SQL statement in the middle of the "year = '..." part.

What is the structure of your database? What are the field types?

Try just for testing to remove the & and then see if it works. If it works then, you will know that is the problem. If you still get the error without the &, then that works, and something else must be wrong, but that is where I would start first.

-Greg

write & like this instead amp;
the gaps in the names could be a problem too

lol...

The problem is from 9-10 year old boys and down you put a ; instead of a : after the case.

ok, i have spent some time on this, and modified it a little. it still doesnt work.

heres the new php:

You can see the page at dscpool.com/records

have you tried echoing your values after the switch statement, or echoing the $sql value before the query

Yes, i just did...and here's the results
UPDATE SET name = 'test', time = '5:25.11', year = '1235' WHERE event = '25 Free''

Not sure if this will help at all, but i get problems whenever i use column names that are also SQL reserved functions or language reserved words.

For example you should avoid naming columns "group" because SQL gets confused when it sees the word group, Ive had similar problems with USER, URL and someother weird ones. When in doubt add My.. so try MyGroup or Group1 as the column name...

This may not help in this case, but its good practice yo

GL!

- oh, one more thing, try breakingit down to the simplest esence, like one case, or use hardcodd values before you start using cariables make sure you basic SQL code is solid...

Yeah it works...thanks to abhishek