PHP problems with "
I just realized that if someone post something on my site that has a " in the title, the listing page doesn't work.
<?php
// if string length is zero, or does not exist
if(strlen($bg) == "0") { $bg = "{PAGETITLE}";}
?>
<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN"
"http://www.w3.org/TR/html4/loose.dtd">
<html>
<head>
<title><?php echo "$bg" ?> - Tidget.com</title>I tried this
<?php
echo addslashes("$bg");
?>Here's an example of what is happening http://tidget.com/comments.php?id=11
Renegade posted this at 04:37 — 5th May 2006.
He has: 3,022 posts
Joined: Oct 2002
Is there any reason why you would have
<?phpecho addslashes(\"$bg\");
?>
Try using just
<?phpecho addslashes($bg);
?>
and see if that helps.
CptAwesome posted this at 14:38 — 5th May 2006.
He has: 370 posts
Joined: Dec 2004
Is this a header you are including or a template that is being brought in by the forum. If it is not being included, the code will not be executed.
teammatt3 posted this at 22:13 — 5th May 2006.
He has: 2,102 posts
Joined: Sep 2003
That doesn't work either Renegade. I think the problem lies here
<?php
// if string length is zero, or does not exist
if(strlen($bg) == "0") { $bg = "{PAGETITLE}";}
?>
because if {PAGETITLE} has a " in it that messes the PHP up, because there are already quote there. I could change it to ' instead of " but then if the pagetitle had a ' in it, the same problem would occur.
Capt. I am not sure what you mean, you can take a look at the whole code here http://tidget.com/templates/default/wrapper.tpl
CptAwesome posted this at 23:01 — 5th May 2006.
He has: 370 posts
Joined: Dec 2004
How is wrapper.tpl being brought into the script? Is it by the forum's template engine which does not execute php? I went to the link you provided and the php code isn't being executed, the problem isn't the code, it's how you are trying to utilize it. Since you're pulling it from a .tpl file, it's being dumped in AFTER the php has been executed, or it's being dumped in as A STRING not as php executable code.
teammatt3 posted this at 01:30 — 6th May 2006.
He has: 2,102 posts
Joined: Sep 2003
It is by the forum's template engine, which does not execute the PHP. So what you're saying is I have to find the source of where the {PAGETITLE} is being built in PHP and go from there?
Is there a JavaScript that can prevent people from typing ' or ", or is that impossible with JavaScript?
CptAwesome posted this at 04:59 — 6th May 2006.
He has: 370 posts
Joined: Dec 2004
What are you trying to do exactly?
teammatt3 posted this at 05:06 — 6th May 2006.
He has: 2,102 posts
Joined: Sep 2003
Well, when someone creates a new listing on the site, the title of the listing is also the pagetitle. If the pagetitle has a ' or " in it, I get an error. I am going to forget working on that PHP and I am now focusing on getting a javascript that will prevent someone from using ' or " in the pagetitle. Thanks for all the help CptAwesome and Renegade.
CptAwesome posted this at 05:10 — 6th May 2006.
He has: 370 posts
Joined: Dec 2004
string = 'input "string" yeah';string = string.replace(/["']/,'');
That will replace all " and ' with nothing (ie killing them) if you run it as an onkeypress or something to that effect on a textarea/input box, that would eliminate the problem.
Want to join the discussion? Create an account or log in if you already have one. Joining is fast, free and painless! We’ll even whisk you back here when you’ve finished.