need some php help - code

$result is usually the variable called, $result could be the table in your database which is set to $n, which is then broken down into id, time, poster etc

is that code complete? looks like its missing a closing bracket "}"

the others may be able to shed more light on this, as i'm no expert in php yet

Quote: Originally posted by Busy
$result is usually the variable called, $result could be the table in your database which is set to $n, which is then broken down into id, time, poster etc

is that code complete? looks like its missing a closing bracket "}"

the others may be able to shed my light on this, as i'm no expert in php yet

hmm lol you mind explaining that in english a bit more?

sorry this is the complete code -

My next question is upon what you said how would I go about fixing that code?
So it will then display the news properly?

thanks for the reply

edit - sorry the common file has the

init so it is easier to update the connection if I have to move hosts or databases again

thanks

Quote: Originally posted by killmaster

I have been told that the $result means nothign and that it needs to be set by an actual query before I can use it.
My question is what the heck does that mean and can someone please share with me the code and explain what it does?

$result is just a variable that can be anything. What is in common.php? A query would be just a SELECT fieldname from db_table

this is the code in the common.php file

this is the database connection code in which then I will only have to change one file instead of all if it needs to be updated

ok here is another script I have decided to create -

http://157.238.47.212/mynews.zip

Except I was wondering as I don't know what the heck is going on I was wondering if someone would be able to debug the code?

Make it work just to post and view news.
Something is also going on when I try and create the table as well but I don't know what

thanks alot for all your help

Well the first thing that I would do is fix your database. Here is your code:

Several things that I would do. One is to make the primary field, message_id instead of id. This way if you join tables, it avoids same column names. Then you really don't need a default value for the id. It will start at 1 and go up from there. I would make the headline field, probably a varchar of fixed length to prevent a too long headline or wasted space. Time doesn't need to be text either. You could make it an integer, insert the value as a Unix timestamp get you values that way. Poster should also be varchar(30-50).

I didn't really get to look at the other code. What kind of problems are you having?

hmm thanks for that I will fix the add database code of it
as for the problems I will get back to you on that one gtg be back tommorrow

thanks

Hey killmaster,

I looked at common.php and your display news page. Looks like your missing two lines of php code.

Try this in your display news code.

include("common.php");
$sql = "Select * From messages Limit 0,5";
$result = mysql_query($sql) OR die(mysql_error());
while($n = mysql_fetch_array($result)) {

That should select your last 5 inserted messages. If you want more just make the 5 into something bigger.

giv eme a sec and I will let you know

Quote: Originally posted by mairving
Well the first thing that I would do is fix your database. Here is your code:

<?php
$create = \"CREATE TABLE messages( id (int, value: 11, default: 1, auto_increment, primary)
poster (text)
headline (text)
time(text)
message (longtext)
?>

Doesn't work this is wthe whole code im using...

<?php
$db = mysql_pconnect(\"localhost\",\"samcoleb_kill\",\"trustnoone\");
mysql_select_db(\"samcoleb_news\",$db);
$create = \"CREATE TABLE messages( id (int, value: 11, default: 1, auto_increment, primary)
poster (text)
headline (text)
time(text)
message (longtext)

;\";
mysql_query($create);

?>

this is what I get when I try and view the news
[b]
Table 'samcoleb_news.messages' doesn't exist

http://157.238.47.212/admin/displaynews.php

If the create table sql isn't working then there obviously isn't going to be a messages table, so thats why the second part won't work. The create table sql you have seems to be missing a parenthesis. You need one more parenthesis at the end to close the one that started after messages(. So the end should look like:

message (longtext))

That doesn't look like a correct SQL statement.

mySQL Docs:
6.5.3 CREATE TABLE Syntax

Try this:
CREATE TABLE messages(id int(11) DEFAULT 1 AUTO_INCREMENT PRIMARY KEY, poster TEXT, headline TEXT, time TEXT, message LONGTEXT)

thanks im busy tonight so I can't try that but I have thursday, friday and the weekend of to try everything out then.

Will let you know hoiw it works out

thanks